Skip to content

[esp32] Use arduino 3.1.3 as default #8604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 71 commits into
base: dev
Choose a base branch
from

Conversation

swoboda1337
Copy link
Contributor

@swoboda1337 swoboda1337 commented Apr 22, 2025

What does this implement/fix?

Move to 3.1.3 which uses IDF 5.3.2, supports C6, P4 and H2 now

Note the esp32_hall component was removed: https://docs.espressif.com/projects/arduino-esp32/en/latest/migration_guides/2.x_to_3.0.html#hall-sensor

Can be used as an external component with 2025.6:

external_components:    
  - source: github://pr#8604
    components: [ac_dimmer, async_tcp, captive_portal, esp32, esp32_rmt, esp32_rmt_led_strip, ethernet, heatpumpir, http_request, i2c, i2s_audio, ledc, logger, md5, neopixelbus, network, nextion, online_image, remote_base, remote_receiver, remote_transmitter, web_server_base, wifi]
    refresh: 1h

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

  • fixes

Pull request in esphome-docs with documentation (if applicable):

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 9.25926% with 49 lines in your changes missing coverage. Please review.

Project coverage is 15.97%. Comparing base (4d8b5ed) to head (14d64f8).
Report is 2854 commits behind head on dev.

Files with missing lines Patch % Lines
esphome/components/esp32/__init__.py 23.07% 10 Missing ⚠️
esphome/components/remote_receiver/__init__.py 0.00% 9 Missing ⚠️
esphome/components/remote_transmitter/__init__.py 0.00% 9 Missing ⚠️
esphome/components/esp32_rmt_led_strip/light.py 0.00% 4 Missing ⚠️
esphome/components/async_tcp/__init__.py 0.00% 3 Missing ⚠️
esphome/components/neopixelbus/light.py 0.00% 3 Missing ⚠️
esphome/components/network/__init__.py 40.00% 2 Missing and 1 partial ⚠️
...home/components/i2s_audio/media_player/__init__.py 0.00% 2 Missing ⚠️
esphome/components/captive_portal/__init__.py 0.00% 1 Missing ⚠️
esphome/components/heatpumpir/climate.py 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #8604       +/-   ##
===========================================
- Coverage   53.70%   15.97%   -37.74%     
===========================================
  Files          50     1164     +1114     
  Lines        9408    48486    +39078     
  Branches     1654     5826     +4172     
===========================================
+ Hits         5053     7747     +2694     
- Misses       4056    40189    +36133     
- Partials      299      550      +251     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@swoboda1337 swoboda1337 marked this pull request as ready for review June 9, 2025 18:33
@probot-esphome
Copy link

probot-esphome bot commented Jun 9, 2025

Hey there @rob-deutsch, mind taking a look at this pull request as it has been labeled with an integration (heatpumpir) you are listed as a code owner for? Thanks!
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (esp32) you are listed as a code owner for? Thanks!
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (md5) you are listed as a code owner for? Thanks!
Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (i2s_audio) you are listed as a code owner for? Thanks!
Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (esp32_rmt_led_strip) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

# https://github.com/esphome/AsyncTCP/blob/master/library.json
cg.add_library("esphome/AsyncTCP-esphome", "2.1.4")
elif CORE.is_esp32:
# https://github.com/esphome/AsyncTCP/blob/master/library.json
cg.add_library("esphome/AsyncTCP-esphome", "2.0.0")
Copy link
Contributor Author

@swoboda1337 swoboda1337 Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a previous version of the library. There were some IPv6 changes that never got used, which don't work with Arduino 3

@@ -125,6 +125,8 @@ def set_core_data(config):
choices = CPU_FREQUENCIES[variant]
if "160MHZ" in choices:
cpu_frequency = "160MHZ"
elif "360MHZ" in choices:
cpu_frequency = "360MHZ"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

400mhz is not supported yet and Arduino will panic and reset


wifi:
ssid: MySSID
password: password1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test had a web server with no wifi or ethernet?

@@ -4,6 +4,7 @@ esphome:

esp32:
board: esp32-c6-devkitc-1
flash_size: 8MB
Copy link
Contributor Author

@swoboda1337 swoboda1337 Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The board is actually 8mb but it was using 4mb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants