Configuration Updates for Wokwi and Hardware Testing Integration #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results11 files 11 suites 53s ⏱️ Results for commit dbdaf1d. ♻️ This comment has been updated with latest results. |
tomassebestik
force-pushed
the
fix/small-updates-wokwi-integration
branch
3 times, most recently
from
624081a to
1b8ee13
Compare
tomassebestik
force-pushed
the
fix/small-updates-wokwi-integration
branch
from
1b8ee13 to
2dae505
Compare
tomassebestik
changed the title
tomassebestik
requested review from
pedrominatel,
urish and
igrr
and removed request for
pedrominatel
|
@urish Thank you again for the great addition in #5. This template is a much cooler project now 🙂. We needed to make a few tweaks to get it working (it's hard to guess in code review since we don't have GH Actions running in forks). Those changes are in this commit. The rest of this PR is about adding some utilities and linting tools for the project itself (not related to implementation). (I added you as a project member, so if you want to contribute to this again in the future you can create branches (with GH Actions running) instead of using forks.) |
".pre-commit-config.yaml" is only addition, the rest of the files changed in this commit are result of running pre-commit run --all-files (all formatters and linters over all files).
tomassebestik
force-pushed
the
fix/small-updates-wokwi-integration
branch
from
51dd36a to
dbdaf1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR after the merge of #5. There are some small tweaks to the configuration needed to ensure both scenarios (hardware tests and Wokwi tests) work properly.
Fixes
Other changes
NOTE: A few files in this PR have slightly changed (spaces, indents, typos, missing empty lines) as a result of running
pre-commit run --all-files(all linters and formatters over all repository files).All these linted files are in a separate commit for easier review.