Making ScheduleAuthorizationRequestJob work for Particulier

etalab · Aug 16, 2023 · e2dbbf6 · e2dbbf6
1 parent b61be83
commit e2dbbf6
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 11 deletions.
diff --git a/app/interactors/datapass_webhook/schedule_authorization_request_emails.rb b/app/interactors/datapass_webhook/schedule_authorization_request_emails.rb
@@ -1,9 +1,7 @@
 class DatapassWebhook::ScheduleAuthorizationRequestEmails < ApplicationInteractor
   def call
     (datapass_webhooks_config_for_event[:emails] || []).each do |email_config|
-      schedule_email(
-        email_config.stringify_keys
-      )
+      schedule_email(email_config.stringify_keys)
     end
   end
 

diff --git a/app/jobs/concerns/mailjet_helpers.rb b/app/jobs/concerns/mailjet_helpers.rb
@@ -19,6 +19,16 @@ def build_mailjet_error_context(mailjet_exception)
     }
   end
 
+  def from_name(api)
+    "API #{api.capitalize}"
+  end
+
+  def from_email(api)
+    mailer_klass = "API#{api.capitalize}Mailer".constantize
+
+    mailer_klass.default_params[:from]
+  end
+
   private
 
   def sanitize_message_payload(message)

diff --git a/app/jobs/schedule_authorization_request_mailjet_email_job.rb b/app/jobs/schedule_authorization_request_mailjet_email_job.rb
@@ -12,7 +12,7 @@ def perform(authorization_request_id, authorization_request_status, mailjet_attr
     return if authorization_request_status_changed?(authorization_request_status)
 
     deliver_mailjet_email(
-      build_message(mailjet_attributes.stringify_keys)
+      build_message(mailjet_attributes.stringify_keys, @authorization_request.api)
     )
   rescue Mailjet::ApiError => e
     affect_mailjet_context_for_sentry(e)
@@ -21,10 +21,10 @@ def perform(authorization_request_id, authorization_request_status, mailjet_attr
 
   private
 
-  def build_message(mailjet_attributes)
+  def build_message(mailjet_attributes, api)
     {
-      from_name: 'API Entreprise',
-      from_email: APIEntrepriseMailer.default_params[:from],
+      from_name: from_name(api),
+      from_email: from_email(api),
       to: build_recipient_attributes(mailjet_attributes['to']),
       cc: build_recipient_attributes(mailjet_attributes['cc']),
       vars: mailjet_attributes['vars'],

diff --git a/spec/jobs/schedule_authorization_request_mailjet_email_job_spec.rb b/spec/jobs/schedule_authorization_request_mailjet_email_job_spec.rb
@@ -66,8 +66,8 @@
       it 'calls Mailjet client with valid params' do
         expect(Mailjet::Send).to receive(:create).with(
           {
-            from_name: anything,
-            from_email: anything,
+            from_name: 'API Entreprise',
+            from_email: APIEntrepriseMailer.default_params[:from],
             to: "#{to_user.full_name} <#{to_user.email}>",
             vars: mailjet_template_vars,
             'Mj-TemplateLanguage' => true,
@@ -83,8 +83,8 @@
       it 'calls Mailjet client with valid params' do
         expect(Mailjet::Send).to receive(:create).with(
           {
-            from_name: anything,
-            from_email: anything,
+            from_name: 'API Entreprise',
+            from_email: APIEntrepriseMailer.default_params[:from],
             to: "#{to_user.full_name} <#{to_user.email}>",
             vars: mailjet_template_vars,
             'Mj-TemplateLanguage' => true,
@@ -191,5 +191,24 @@
         end
       end
     end
+
+    describe 'with api Particulier' do
+      let(:authorization_request) { create(:authorization_request, status: authorization_request_status, api: 'particulier') }
+
+      it 'calls Mailjet client with valid params' do
+        expect(Mailjet::Send).to receive(:create).with(
+          {
+            from_name: 'API Particulier',
+            from_email: APIParticulierMailer.default_params[:from],
+            to: "#{to_user.full_name} <#{to_user.email}>",
+            vars: mailjet_template_vars,
+            'Mj-TemplateLanguage' => true,
+            'Mj-TemplateID' => mailjet_template_id
+          }.stringify_keys
+        )
+
+        subject
+      end
+    end
   end
 end