Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean deprecated INPI Actes Endpoint #1619

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

Samuelfaure
Copy link
Contributor

No description provided.

@Samuelfaure Samuelfaure marked this pull request as ready for review August 1, 2024 05:08
Copy link
Member

@skelz0r skelz0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contrairement à ce que j'ai dit ici https://github.com/etalab/siade/pull/1314#issuecomment-2262879029 cette PR est OK car dtf cette API est down no matter what donc bon..

Par contre on est d'accord que ce n'est pas à merger avant que https://github.com/etalab/siade/pull/1298 soit fixé/mergé ?

@@ -37,12 +37,6 @@ def custom_provider_errors
end
end

def force_dummy_load?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels-good

@Samuelfaure
Copy link
Contributor Author

@skelz0r IMO on peut déjà merger vu que la route est down 🤷 on cache déjà cette fiche dans le catalogue tfaçon

@skelz0r skelz0r merged commit 126328b into develop Aug 2, 2024
6 checks passed
@skelz0r skelz0r deleted the clean/actes_deprecated branch August 2, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants