Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move exclude-files to issues section #35

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

henrybear327
Copy link
Contributor

Tidy up the golangci config file according to the PR discussion in etcd repo

Reference:

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henrybear327 the change looks good, can you please sign off the commit so we can merge? Thanks! 🙏🏻

Tidy up the golangci config file according to the PR discussion in etcd
repo

Reference:
- etcd-io/etcd#17694 (comment)

Signed-off-by: Chun-Hung Tseng <[email protected]>
@henrybear327 henrybear327 force-pushed the fix/golangci-link-config branch from 9148dcb to 6b7c2d3 Compare April 2, 2024 22:48
@henrybear327 henrybear327 requested a review from jmhbnz April 2, 2024 22:50
Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmhbnz jmhbnz merged commit 873f8ef into etcd-io:master Apr 4, 2024
3 checks passed
@henrybear327 henrybear327 deleted the fix/golangci-link-config branch April 4, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants