chore : add the Validate and AddFlags() function
#1135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lavish Pal <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lavishpal The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
lavishpal
changed the title
Validate and AddFlags() functionValidate and AddFlags() function
Member
|
/ok-to-test |
Member
Member
|
raised #1136 for fix the failing test |
ahrtr
reviewed
Jan 17, 2026
Comment on lines
+71
to
+78
| path := args[0] | ||
| buckets := args[1 : len(args)-1] | ||
| keyStr := args[len(args)-1] | ||
|
|
||
| key, err := parseBytes(keyStr, o.parseFormat) | ||
| if err != nil { | ||
| return err | ||
| } |
Member
There was a problem hiding this comment.
This seems duplicated to the validate.
It is OK to add a separate AddFlags, but I do not see much value to add a separate Validate. Two proposals:
- [preferred] remove the
Validatemethod, do the validation in Run directly. - add the parsed arguments as fields in
getOptions, so thatRuncan use them directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr add the
ValidateandAddFlags()function in thecommand_get.gopart of #1026
ref comment