Skip to content

Commit

Permalink
Merge pull request #18058 from jmhbnz/prow-migration
Browse files Browse the repository at this point in the history
Complete migration of verify workflow to prow
  • Loading branch information
ahrtr authored May 23, 2024
2 parents 6774334 + 32726e7 commit 7a3ca53
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 47 deletions.
46 changes: 0 additions & 46 deletions .github/workflows/static-analysis.yaml

This file was deleted.

3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ releases.

## Get your pull request reviewed

Before requesting review please ensure that all GitHub checks were successful.
Before requesting review please ensure that all GitHub and Prow checks are successful. In some cases your pull request may have the label `needs-ok-to-test`. If so an `etcd-io` organisation member will leave a comment on your pull request with `/ok-to-test` to trigger all checks to be run.

It might happen that some unrelated tests on your PR are failing, due to their flakiness.
In such cases please [file an issue] to deflake the problematic test and ask one of [maintainers] to rerun the tests.

Expand Down
4 changes: 4 additions & 0 deletions Documentation/contributor-guide/triage_prs.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ Following are a few example searches on PR for convenience:

These guidelines serve as a primary document for managing PRs in `etcd`. Everyone is welcome to help manage PRs but the work and responsibilities discussed in this document are created with `etcd` maintainers and active contributors in mind.

## Ensure tests are run

The etcd project use Kubernetes Prow and GitHub Actions to run tests. To ensure all required tests run if a pull request is ready for testing and still has the `needs-ok-to-test` label then please comment on the pull request `/ok-to-test`.

## Handle inactive PRs
Poke PR owner if review comments are not addressed in 15 days. If the PR owner does not reply in 90 days, update the PR with a new commit if possible. If not, inactive PR should be closed after 180 days.

Expand Down

0 comments on commit 7a3ca53

Please sign in to comment.