Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raft: reduce heartbeat msg #11347

Closed
wants to merge 1 commit into from

Conversation

NingLin-P
Copy link

Signed-off-by: linning [email protected]

When there is no pending Readindex, MsgAppend will do the work of MsgHeartbeat, so when we had broadcasted MsgAppend, we can reset heartbeat_elapsed to reduce MsgHeartbeat.

also see: tikv/raft-rs#309 tikv/raft-rs#313

@codecov-io
Copy link

Codecov Report

Merging #11347 into master will decrease coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11347      +/-   ##
==========================================
- Coverage    64.6%   64.47%   -0.14%     
==========================================
  Files         403      403              
  Lines       37969    37973       +4     
==========================================
- Hits        24531    24483      -48     
- Misses      11805    11847      +42     
- Partials     1633     1643      +10
Impacted Files Coverage Δ
raft/raft.go 89.96% <100%> (-0.59%) ⬇️
proxy/httpproxy/director.go 61.42% <0%> (-18.58%) ⬇️
proxy/grpcproxy/register.go 69.44% <0%> (-13.89%) ⬇️
clientv3/naming/grpc.go 63.15% <0%> (-12.29%) ⬇️
client/members.go 56.45% <0%> (-8.88%) ⬇️
clientv3/leasing/util.go 91.66% <0%> (-6.67%) ⬇️
client/client.go 78.43% <0%> (-5.56%) ⬇️
clientv3/leasing/cache.go 87.22% <0%> (-4.45%) ⬇️
proxy/grpcproxy/watcher.go 89.79% <0%> (-4.09%) ⬇️
clientv3/leasing/txn.go 88.09% <0%> (-3.18%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d05459e...fe64ca7. Read the comment docs.

@stale
Copy link

stale bot commented Apr 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 6, 2020
@stale stale bot closed this Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants