Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed: only log stream error with debug level #12406

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

tangcong
Copy link
Contributor

@tangcong tangcong commented Oct 20, 2020

Disable noisy gRPC logs.

22:07:55 etcd1 | {"level":"warn","ts":"2020-10-20T22:07:55.500+0800","caller":"grpclog/grpclog.go:66","msg":"transport: http2Server.HandleStreams failed to read frame: read tcp 127.0.0.1:2379->127.0.0.1:62786: read: connection reset by peer"}
22:07:55 etcd1 | {"level":"info","ts":"2020-10-20T22:07:55.500+0800","caller":"grpclog/grpclog.go:51","msg":"transport: loopyWriter.run returning. connection error: desc = \"transport is closing\""}
22:07:56 etcd1 | {"level":"warn","ts":"2020-10-20T22:07:56.135+0800","caller":"grpclog/grpclog.go:66","msg":"transport: http2Server.HandleStreams failed to read frame: read tcp 127.0.0.1:2379->127.0.0.1:62789: read: connection reset by peer"}
22:07:56 etcd1 | {"level":"info","ts":"2020-10-20T22:07:56.136+0800","caller":"grpclog/grpclog.go:51","msg":"transport: loopyWriter.run returning. connection error: desc = \"transport is closing\""}

@gyuho gyuho merged commit ae962f7 into etcd-io:master Oct 20, 2020
@Sarga Sarga mentioned this pull request Dec 8, 2020
@tangcong tangcong deleted the silence-stream-log branch February 26, 2021 18:57
@niharkawli
Copy link

niharkawli commented Jan 17, 2022

@tangcong @gyuho Is this fix also going to be merged to 3.4 branch? We are seeing these logs with latest 3.4.x - v3.4.18 as well.

@kkkkun
Copy link
Contributor

kkkkun commented Jan 28, 2022

@tangcong @gyuho Is this fix also going to be merged to 3.4 branch? We are seeing these logs with latest 3.4.x - v3.4.18 as well.

It do not cherrypick this PR to 3.4 branch.
https://github.com/etcd-io/etcd/blob/release-3.4/embed/config_logging.go#L198

Let me do this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants