Skip to content

Format the 3.5 changelog #19031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Dec 7, 2024

Followup to #19028

Signed-off-by: Benjamin Wang <[email protected]>
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.81%. Comparing base (bbe48b3) to head (1163691).
Report is 1 commits behind head on main.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19031      +/-   ##
==========================================
+ Coverage   68.77%   68.81%   +0.04%     
==========================================
  Files         420      420              
  Lines       35623    35623              
==========================================
+ Hits        24499    24514      +15     
+ Misses       9695     9683      -12     
+ Partials     1429     1426       -3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbe48b3...1163691. Read the comment docs.

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ahrtr

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 801dfc3 into etcd-io:main Dec 7, 2024
35 checks passed
@ahrtr ahrtr deleted the format_changelog_20241207 branch December 9, 2024 10:10
ivanvc pushed a commit to ivanvc/etcd that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants