scripts: fix shellws pass #19045
scripts: fix shellws pass #19045
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 25 files with indirect coverage changes @@ Coverage Diff @@
## main #19045 +/- ##
==========================================
- Coverage 68.77% 68.75% -0.03%
==========================================
Files 420 420
Lines 35623 35626 +3
==========================================
- Hits 24500 24493 -7
- Misses 9698 9703 +5
- Partials 1425 1430 +5 Continue to review full report in Codecov by Sentry.
|
|
/retest |
ivanvc
force-pushed
the
scripts-simplify-shellws-pass
branch
from
e0ebab7 to
b45036d
Compare
ivanvc
force-pushed
the
scripts-simplify-shellws-pass
branch
from
b45036d to
a83dd58
Compare
|
/retest |
ivanvc
force-pushed
the
scripts-simplify-shellws-pass
branch
from
a83dd58 to
8fdb57d
Compare
scripts/test.sh
Outdated
| if files=$(find . -name '*.sh' -print0 | xargs -0 grep -E -n $'^\s*\t'); then | ||
| log_error "FAIL: found tab-based indention in the following bash scripts. Use ' ' (double space):" | ||
| log_error "${files}" | ||
| log_warning "Suggestion: running \"make fix\" addresses the issue." |
There was a problem hiding this comment.
| log_warning "Suggestion: running \"make fix\" addresses the issue." | |
| log_warning "Suggestion: running \"make fix\" to address the issue." |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Originally this was intended to be a clean up. But after further investigation the original code didn't work. It didn't detect tabs in shell scripts. Signed-off-by: Ivan Valdes <[email protected]>
ivanvc
force-pushed
the
scripts-simplify-shellws-pass
branch
from
8fdb57d to
fad495a
Compare
|
/retest |
The repository scripts now always have the 'sh' extension. Therefore, the find over '*.sh' matches all scripts without the need to append
./scripts/build-binary.sh,./scripts/build-docker.sh, and./scripts/release.sh.Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.