-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set a 80% threshold for the codecov status.patch #19046
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 23 files with indirect coverage changes @@ Coverage Diff @@
## main #19046 +/- ##
==========================================
- Coverage 68.73% 68.71% -0.02%
==========================================
Files 420 420
Lines 35623 35623
==========================================
- Hits 24486 24479 -7
- Misses 9702 9710 +8
+ Partials 1435 1434 -1 Continue to review full report in Codecov by Sentry.
|
cc @fuweid |
The PR doesn't fix the failure of |
@ahrtr, after reading the documentation, I think the behavior that we want is to set the threshold to 99% rather than 1%. Can you try that on your other pull request to see if there's a failure? |
Thanks. Just updated #19041, Let's see what's the result. Most likely it should work. Probably we should just disable it. |
Signed-off-by: Benjamin Wang <[email protected]>
9e1c24c
to
6d84287
Compare
Just changed to 80%, at least it's better than off/disabled. As mentioned above, we still need to depend on Maintainers to whether we should add test to improve the coverage for each PR. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @ahrtr.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Basically we depend on maintainers to decide whether we should add test to improve the coverage for each PR, although we set a 1% threshold for now.