Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a 80% threshold for the codecov status.patch #19046

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Dec 12, 2024

Basically we depend on maintainers to decide whether we should add test to improve the coverage for each PR, although we set a 1% threshold for now.

@ahrtr
Copy link
Member Author

ahrtr commented Dec 12, 2024

cc @ivanvc @jmhbnz @serathius

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.71%. Comparing base (f03dee9) to head (6d84287).
Report is 4 commits behind head on main.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19046      +/-   ##
==========================================
- Coverage   68.73%   68.71%   -0.02%     
==========================================
  Files         420      420              
  Lines       35623    35623              
==========================================
- Hits        24486    24479       -7     
- Misses       9702     9710       +8     
+ Partials     1435     1434       -1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f03dee9...6d84287. Read the comment docs.

@ahrtr
Copy link
Member Author

ahrtr commented Dec 12, 2024

cc @fuweid

@ahrtr
Copy link
Member Author

ahrtr commented Dec 12, 2024

The PR doesn't fix the failure of codecov/patch in #19041. @ivanvc @jmhbnz do you know how to adjust the parameter to fix it? Or we can just disable the patch status.

@ivanvc
Copy link
Member

ivanvc commented Dec 12, 2024

The PR doesn't fix the failure of codecov/patch in #19041. @ivanvc @jmhbnz do you know how to adjust the parameter to fix it? Or we can just disable the patch status.

@ahrtr, after reading the documentation, I think the behavior that we want is to set the threshold to 99% rather than 1%. Can you try that on your other pull request to see if there's a failure?

@ahrtr
Copy link
Member Author

ahrtr commented Dec 12, 2024

@ahrtr, after reading the documentation, I think the behavior that we want is to set the threshold to 99% rather than 1%. Can you try that on your other pull request to see if there's a failure?

Thanks. Just updated #19041, Let's see what's the result. Most likely it should work. Probably we should just disable it.

@ahrtr ahrtr force-pushed the disable_patch_status_20241212 branch from 9e1c24c to 6d84287 Compare December 12, 2024 20:14
@ahrtr ahrtr changed the title Set a 1% threshold for the codecov status.patch Set a 80% threshold for the codecov status.patch Dec 12, 2024
@ahrtr
Copy link
Member Author

ahrtr commented Dec 12, 2024

Just changed to 80%, at least it's better than off/disabled. As mentioned above, we still need to depend on Maintainers to whether we should add test to improve the coverage for each PR.

@ahrtr
Copy link
Member Author

ahrtr commented Dec 12, 2024

@ivanvc yes, it works in #19041.

Please take a look at this PR, let's get it merged firstly. thx

@ivanvc
Copy link
Member

ivanvc commented Dec 12, 2024

/retest

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ahrtr.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 2cf7172 into etcd-io:main Dec 12, 2024
34 checks passed
@ahrtr ahrtr deleted the disable_patch_status_20241212 branch December 12, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants