Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a TODO comment for UnsafeDetectSchemaVersion on how to simplify t… #19047

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Dec 12, 2024

…he implementation

cc @fuweid @serathius @siyuanfoundation

@ahrtr
Copy link
Member Author

ahrtr commented Dec 12, 2024

Link to #19040

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.82%. Comparing base (f03dee9) to head (50e7f9f).
Report is 2 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/storage/schema/schema.go 100.00% <ø> (ø)

... and 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19047      +/-   ##
==========================================
+ Coverage   68.73%   68.82%   +0.08%     
==========================================
  Files         420      420              
  Lines       35623    35623              
==========================================
+ Hits        24486    24516      +30     
+ Misses       9702     9685      -17     
+ Partials     1435     1422      -13     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f03dee9...50e7f9f. Read the comment docs.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 8f447cf into etcd-io:main Dec 12, 2024
35 checks passed
@ahrtr ahrtr deleted the comment_storageversion_20241212 branch December 12, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants