Skip to content

[3.4] Avoid deadlock in etcd.Close when stopping during bootstrapping#19166

Merged
serathius merged 3 commits intoetcd-io:release-3.4from
joshuazh-x:fix-embed-close-deadlock-3.4
Jan 13, 2025
Merged

[3.4] Avoid deadlock in etcd.Close when stopping during bootstrapping#19166
serathius merged 3 commits intoetcd-io:release-3.4from
joshuazh-x:fix-embed-close-deadlock-3.4

Conversation

@joshuazh-x
Copy link
Contributor

@k8s-ci-robot
Copy link

Hi @joshuazh-x. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joshuazh-x joshuazh-x changed the title Fix embed close deadlock 3.4 Backport https://github.com/etcd-io/etcd/pull/19139 to 3.4 Jan 10, 2025
@ivanvc
Copy link
Member

ivanvc commented Jan 10, 2025

/retitle [3.4] Avoid deadlock in etcd.Close when stopping during bootstrapping
/ok-to-test

@k8s-ci-robot k8s-ci-robot changed the title Backport https://github.com/etcd-io/etcd/pull/19139 to 3.4 [3.4] Avoid deadlock in etcd.Close when stopping during bootstrapping Jan 10, 2025
@joshuazh-x joshuazh-x force-pushed the fix-embed-close-deadlock-3.4 branch from b1802ac to a3bf49b Compare January 11, 2025 07:15
@ahrtr
Copy link
Member

ahrtr commented Jan 11, 2025

Please also add a changelog item for 3.4 (link to this PR) and 3.5 (link to #19167) respectively, thx

@joshuazh-x
Copy link
Contributor Author

/retest

@joshuazh-x
Copy link
Contributor Author

Changlog PR #19171

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, joshuazh-x, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit ab34cdb into etcd-io:release-3.4 Jan 13, 2025
@ivanvc ivanvc mentioned this pull request Feb 11, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants