scripts/release: Use go mod instead of go list
#19546
Conversation
Replace `go list -m` with `go mod edit -json`, as the latter can return the same information. This will be helpful when the project migrates to using a Go workspace, as it will return the current module defined in go.mod rather than all the modules from the current directory (using a workspace, the top-level go.mod will return all the child modules from the repository). Signed-off-by: Ivan Valdes <[email protected]>
ivanvc
force-pushed
the
use-go-mod-instead-of-go-list-in-release-scripts
branch
from
50b3f18 to
7e66d3a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 16 files with indirect coverage changes @@ Coverage Diff @@
## main #19546 +/- ##
==========================================
- Coverage 68.83% 68.80% -0.04%
==========================================
Files 421 421
Lines 35901 35901
==========================================
- Hits 24713 24702 -11
- Misses 9768 9776 +8
- Partials 1420 1423 +3 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Replace
go list -mwithgo mod edit -json, as the latter can return the same information. This will be helpful when the project migrates to using a Go workspace, as it will return the current module defined in go.mod rather than all the modules from the current directory (using a workspace, the top-level go.mod will return all the child modules from the repository).Spun off from #19423.
Part of #18409.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.