feat(client/v3/naming): deprecate usage of gresolver.Address.Metadata

[amosehiguese]

This implementation adds the new Addributes field to resolver to better align with gRPC's API as highlighted in issue #19706

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amosehiguese
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @amosehiguese. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[henrybear327]

/ok-to-test

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.88%. Comparing base (0ff4a1a) to head (bd9b6ce).

Files with missing lines	Patch %	Lines
client/v3/naming/resolver/resolver.go	75.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
client/v3/naming/endpoints/endpoints.go	100.00% <ø> (ø)
client/v3/naming/resolver/resolver.go	77.19% <75.00%> (-2.06%)	⬇️

... and 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19732      +/-   ##
==========================================
+ Coverage   68.78%   68.88%   +0.09%     
==========================================
  Files         421      421              
  Lines       35857    35861       +4     
==========================================
+ Hits        24664    24702      +38     
+ Misses       9759     9735      -24     
+ Partials     1434     1424      -10     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ff4a1a...bd9b6ce. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[amosehiguese]

Now I have to fix robustness 😂.

@henrybear327 do you have any suggestions?

Should I add a test case to cover that area?

If yes, should it be under integration tests?

[henrybear327]

It's low qps Requiring minimal 100.000000 qps before failpoint injection for test results to be reliable, got 82.989763 qps, so just rerun it would be ok for now (nothing to fix)

/retest

[amosehiguese]

Phew, what a relief! 😂 Thanks for the clarification though.

I guess I can take up other issues now. Appreciate the support!

Loads of thanks! 😊

[siyuanfoundation]

Given #15145, @ahrtr do you think this PR is still relevant?

[ahrtr]

Thanks for the PR.

For this specific issue #19700, we expect grpc to resolve it instead of etcd. See grpc/grpc-go#8227

We need experienced contributors to work on #15145