Antithesis Integration: Move Antithesis demo to etcd repo #19739
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: abdurrehman107 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -0,0 +1,71 @@ | |||
| FROM golang | |||
There was a problem hiding this comment.
We want to replace this with FROM docker.io/ubuntu:latest as base image correct?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 147 files with indirect coverage changes @@ Coverage Diff @@
## main #19739 +/- ##
==========================================
+ Coverage 61.96% 68.90% +6.94%
==========================================
Files 406 421 +15
Lines 34632 35857 +1225
==========================================
+ Hits 21461 24709 +3248
+ Misses 11595 9735 -1860
+ Partials 1576 1413 -163 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
abdurrehman107
force-pushed
the
abdur-rehman/antithesis-integration
branch
from
b359666 to
5b830dd
Compare
Signed-off-by: Abdur Rehman <[email protected]>
abdurrehman107
force-pushed
the
abdur-rehman/antithesis-integration
branch
from
cf3c554 to
da055ae
Compare
| @@ -0,0 +1,70 @@ | |||
| FROM docker.io/ubuntu:latest | |||
There was a problem hiding this comment.
Please cleanup and remove things not needed
| Attaching to client, etcd0, etcd1, etcd2 | ||
| client | exec /entrypoint.py: exec format error | ||
| etcd2 | etcd 14:02:27.85 INFO ==> | ||
| etcd2 | etcd 14:02:27.86 INFO ==> Welcome to the Bitnami etcd container |
There was a problem hiding this comment.
We don't use bitnami any more, please test the scripts and provide updated results.
| ```yaml | ||
| services: | ||
| etcd0: | ||
| image: docker.io/bitnami/etcd:3.5 |
There was a problem hiding this comment.
@serathius aside from replacing bitnami, do we want to consider using 3.6.x-rc or a more recent 3.5 version so we are testing against something that's more "recent"?
There was a problem hiding this comment.
For now latest stable is enough. Lets start with 3.5
| ALLOW_NONE_AUTHENTICATION: "yes" | ||
|
|
||
| etcd1: | ||
| image: 'quay.io/coreos/etcd:v3.5.0' |
|
/ok-to-test |
|
@abdurrehman107: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| ALLOW_NONE_AUTHENTICATION: "yes" | ||
|
|
||
| etcd2: | ||
| image: 'docker.io/bitnami/etcd:3.5' |
This PR moves parts of the demo to the etcd repo. I've also run the tests locally and setup a demo cluster using docker-compose.
cc @serathius