1537: serialize the chunk update #1541
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mahanteshwar-git The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mahanteshwar-git
force-pushed
the
fix/1537_serialize_chunk_updates
branch
from
6de3a2e to
fe9dd02
Compare
Signed-off-by: mchimang <[email protected]>
mahanteshwar-git
force-pushed
the
fix/1537_serialize_chunk_updates
branch
from
fe9dd02 to
00ab589
Compare
mahanteshwar-git
changed the title
Author
|
@lburgazzoli , could you please review the code. |
lburgazzoli
reviewed
Nov 17, 2025
| final Long bytes = maintenance.snapshot(NullOutputStream.INSTANCE).get(); | ||
| final AtomicLong count = new AtomicLong(); | ||
| final CountDownLatch latcht = new CountDownLatch(1); | ||
| ReentrantLock reentrantLock = new ReentrantLock(true); |
Collaborator
There was a problem hiding this comment.
how the re-entrant lock helps here ? the count si already an atomic value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix the flaky test case: testSnapshotChunks by serializing the calls to the handlers.