Test: Replace t.error/fatal with assert/request in [/tracker/inflights_test.go] #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
approved these changes
Apr 3, 2024
pav-kv
reviewed
Apr 3, 2024
MrDXY
force-pushed
the
replace-test-errors-with-assert-tracker
branch
from
b2403c5
to
a6f8e3e
Compare
pav-kv
approved these changes
Apr 4, 2024
|
We need to bump the go version to fix the workflow failure (CVE). FYI. etcd-io/etcd#17703 |
|
I can work on bumping the go version. |
Sure, feel free to raise a PR. |
Signed-off-by: Xinyuan Du <[email protected]>
MrDXY
force-pushed
the
replace-test-errors-with-assert-tracker
branch
from
a6f8e3e
to
ca660d6
Compare
|
Hi, folks, since the go version has been bumped, the git workflow should now be functioning smoothly. The PR is all set for a second review. whenever you find a moment, please take a look. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: Replacing t.Error/t.Fatal with assert/require
This commit tries to eliminate boilerplate code in the testing suite by replacing occurrences
of t.Error and t.Fatal with assertions from the assert and require packages.
Changes Made:
Affected Files:
Part of: #146