Skip to content

docs: Update reference to etcd-cpp-apiv3 #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rajachan
Copy link

The external repo redirects from the nokia org to etcd-cpp-apiv3 now.

@k8s-ci-robot
Copy link

Hi @rajachan. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

The external repo redirects from the nokia org to etcd-cpp-apiv3 now.

Signed-off-by: Raghu Raja <[email protected]>
@ivanvc
Copy link
Member

ivanvc commented May 28, 2025

/ok-to-test

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @rajachan

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @rajachan.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz, rajachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivanvc
Copy link
Member

ivanvc commented May 28, 2025

Oh no, sorry. After I clicked 'Approve', I realized that this pull request updates the 3.3 docs. @rajachan, would you mind updating 3.5 and 3.6, rather than 3.3?

Apologies, and thanks.

@jmhbnz
Copy link
Member

jmhbnz commented May 29, 2025

Oh no, sorry. After I clicked 'Approve', I realized that this pull request updates the 3.3 docs. @rajachan, would you mind updating 3.5 and 3.6, rather than 3.3?

Good catch!

@jberkus
Copy link
Contributor

jberkus commented Jun 5, 2025

/hold

@rajachan please update the 3.6 docs, then backport. Thanks!

@rajachan
Copy link
Author

rajachan commented Jun 5, 2025

Missed the earlier comment, yes, will push an update.

@wendy-ha18
Copy link
Contributor

Hi @rajachan, just checking in are things all good with the update link of etcd-cpp-apiv3 for v3.5 and v3.6 docs?

Also want to heads-up with you that the main branch has had a few recent changes, so you might need to pull the latest updates before proceeding.

It would be great to get this PR merged soon as this is a quick fix. However, no blockers since this PR just updates reference links, feel free to do it when you have time.

Thanks!

@ivanvc ivanvc requested review from ivanvc and jmhbnz July 25, 2025 06:35
@ivanvc
Copy link
Member

ivanvc commented Jul 25, 2025

Oops, I wanted to remove my approval, and I double-clicked and removed yours, James.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants