-
Notifications
You must be signed in to change notification settings - Fork 320
docs: Update reference to etcd-cpp-apiv3 #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @rajachan. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The external repo redirects from the nokia org to etcd-cpp-apiv3 now. Signed-off-by: Raghu Raja <[email protected]>
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @rajachan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @rajachan.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivanvc, jmhbnz, rajachan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Oh no, sorry. After I clicked 'Approve', I realized that this pull request updates the 3.3 docs. @rajachan, would you mind updating 3.5 and 3.6, rather than 3.3? Apologies, and thanks. |
Good catch! |
/hold @rajachan please update the 3.6 docs, then backport. Thanks! |
Missed the earlier comment, yes, will push an update. |
Hi @rajachan, just checking in are things all good with the update link of etcd-cpp-apiv3 for v3.5 and v3.6 docs? Also want to heads-up with you that the main branch has had a few recent changes, so you might need to pull the latest updates before proceeding. It would be great to get this PR merged soon as this is a quick fix. However, no blockers since this PR just updates reference links, feel free to do it when you have time. Thanks! |
Oops, I wanted to remove my approval, and I double-clicked and removed yours, James. |
The external repo redirects from the nokia org to etcd-cpp-apiv3 now.