Etc mystique #1
Draft
Etc mystique #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
meowsbits
commented
Oct 25, 2022
•
meowsbits
commented
- (client) core-geth development branch: https://github.com/etclabscore/core-geth/tree/merge/foundation-release/1.10.23-tests-generate-fixes-statefix-difficulty-test-v2-ripemd-tx-debug
winsvega
reviewed
Oct 25, 2022
|
|
||
| # Run a single test, alternate command. | ||
| # NOTE: It is not clear what the root directory of the 'testfile' argument should be. "tests/"? The absolute path to the tests/ directory? | ||
| # The former works for me as expected, the latter seems to cause ./dretesteth to run eternally (or a long time). |
There was a problem hiding this comment.
Ths is a bug
The path to file should be as of inside the docker where testpath is mounted
| # Fill tests for a suite of tests, still for a single fork. | ||
| # ./dretesteth.sh -t GeneralStateTests/stArgsZeroOneBalance -- --filltests --testpath "${testspath}" --clients t8ntooletc --singlenet ETC_Mystique | ||
| ./build/retesteth/retesteth -t GeneralStateTests/stArgsZeroOneBalance -- --filltests --testpath "${testspath}" --clients t8ntooletc --singlenet ETC_Mystique | ||
| # Beware, this one takes a long time. |
There was a problem hiding this comment.
You can use -j thread option.
Dont fill batch tests with selectors, the geneated files will be incomplete. Selectors are for debug (singlenet t d v)
There was a problem hiding this comment.
Is there any value in thinking about a --forks (or --pluralnets 😜) flag, so you could choose a subset of forks? For example, so we could fill test files that only contained ETC_ forks?
so that if you mostly use chainID 5 after 1 most of the transactions init with 5 and no convertion needed
…th clone Date: 2022-10-25 08:45:19-07:00 Signed-off-by: meows <[email protected]>
I assume these are comparable fork values, and hope this will introduce retesteth support for ETC's Mystique fork. Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
This reverts commit 47c1e3c.
This reverts commit 7bc71fe.
…/core-geth" This reverts commit 5c98609.
This reverts commit e9b7b4e.
…emote with clone" This reverts commit 1ef050b.
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
This reverts commit 5eca8d8.
Note that this ALSO (re)sets the chainID - the 'global' chain id - to 1 for compatibility with ETH. Signed-off-by: meows <[email protected]>
meowsbits
force-pushed
the
etc-mystique
branch
from
711770b
to
9e6dc0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.