-
Notifications
You must be signed in to change notification settings - Fork 29
cmake cleanup #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake cleanup #145
Conversation
cscs-ci run default |
cscs-ci run ALPS-DAINT |
1e6f1f7
to
236d584
Compare
cscs-ci run ALPS-DAINT |
7e2df12
to
a0ffe23
Compare
8406ff8
to
fa57f8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a minor modification but otherwise looks good to me
cscs-ci run ALPS-DAINT |
cscs-ci run GH200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
CMakeLists.txt
Outdated
@@ -153,6 +156,7 @@ if (COSMA_WITH_TESTS OR COSMA_WITH_APPS) | |||
cxxopts | |||
GIT_REPOSITORY https://github.com/jarro2783/cxxopts.git | |||
GIT_TAG 4bf61f08697b110d9e3991864650a405b3dd515d # v3.2.1 | |||
FIND_PACKAGE_ARGS NAMES cxx-opts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it cxxopts
without the -
?
COSMA uses FetchContent to find and if not found build costa and Tiled-MM.