Skip to content

cmake cleanup #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 8, 2025
Merged

cmake cleanup #145

merged 10 commits into from
May 8, 2025

Conversation

mtaillefumier
Copy link
Collaborator

@mtaillefumier mtaillefumier commented Oct 25, 2024

COSMA uses FetchContent to find and if not found build costa and Tiled-MM.

@simonpintarelli
Copy link
Member

cscs-ci run default

@simonpintarelli
Copy link
Member

cscs-ci run ALPS-DAINT

@mtaillefumier
Copy link
Collaborator Author

cscs-ci run ALPS-DAINT

Copy link
Collaborator Author

@mtaillefumier mtaillefumier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor modification but otherwise looks good to me

@simonpintarelli
Copy link
Member

cscs-ci run ALPS-DAINT

@simonpintarelli
Copy link
Member

cscs-ci run GH200

Copy link
Member

@simonpintarelli simonpintarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CMakeLists.txt Outdated
@@ -153,6 +156,7 @@ if (COSMA_WITH_TESTS OR COSMA_WITH_APPS)
cxxopts
GIT_REPOSITORY https://github.com/jarro2783/cxxopts.git
GIT_TAG 4bf61f08697b110d9e3991864650a405b3dd515d # v3.2.1
FIND_PACKAGE_ARGS NAMES cxx-opts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it cxxopts without the -?

@simonpintarelli simonpintarelli merged commit 5ce36f9 into master May 8, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants