Multi Currency support #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coinbase API returns 'None" when the currency variable is set to 'DOGE-USD' but returns the ID when you just put 'DOGE'
…ading and fixing some of the bugs
|
why remov readme.md tho |
|
i need to add a system that adds an error message when a buy fails, and the stop loss sell all function doesn't work yet. |
…idual currencies. cleaned up some code and fixed some bugs
…top loss function. Made each currency have its own buy variable, so when the BuySell function wants to stop selling it can do it selectively
… variable is invested
|
I think the selling function isn't working, ill do some troubleshooting tonight... |
…ixed the selling part of the BuySell function :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I found your script on the internet one day, and just wanted to see what you think of the changes I made to it. I know this is probably a dead project but I still want to contribute, I hope you find this useful and would appreciate feedback if you have any.