Skip to content

Testing/language fix #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Testing/language fix #317

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3062cb1
Show title attribute
SamTV12345 Aug 9, 2023
18136a6
Increase timeout.
SamTV12345 Aug 9, 2023
a3bc09a
Fixed line endings. Use exact code snippet from etherpad.
SamTV12345 Aug 9, 2023
f5db919
Added missing await.
SamTV12345 Aug 9, 2023
ae2cd9b
Don't return promise.
SamTV12345 Aug 9, 2023
2484257
Don't return promise.
SamTV12345 Aug 9, 2023
9f3d2c5
Use ==
SamTV12345 Aug 9, 2023
9f5c091
Output for testing.
SamTV12345 Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions static/tests/frontend/specs/comment_l10n.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,22 +112,18 @@ const changeEtherpadLanguageTo = async (lang) => {

// click on the settings button to make settings visible
const $settingsButton = chrome$('.buttonicon-settings');
$settingsButton.click();
$settingsButton.trigger('click');

// select the language
// click the language button
const $language = chrome$('#languagemenu');
const $languageoption = $language.find(`[value=${lang}]`);
$languageoption.attr('selected', 'selected');
// select passed language
$language.val(lang);
$language.trigger('change');

// hide settings again
$settingsButton.click();

await helper.waitForPromise(
() => {
console.log(chrome$('.buttonicon-bold').parent()[0].title);
return chrome$('.buttonicon-bold').parent()[0].title === boldTitles[lang];
});
// get the value of the bold button
const $boldButton = chrome$('.buttonicon-bold').parent();
console.log($boldButton[0].title);
return helper.waitForPromise(() => $boldButton[0].title === boldTitles[lang]);
};

const getCommentId = () => {
Expand Down