Skip to content

Conversation

HMarzban
Copy link

@HMarzban HMarzban commented Mar 4, 2021

1/ Upgrade the socket.io-client package to v3
2/ update code base for socketIO v3

@SamTV12345
Copy link
Member

Hi @HMarzban . I know it's been a while since you started your work. Is this pr done? Would you have time to help me migrate Etherpad to v3/v4 of socket.io?

@HMarzban
Copy link
Author

HMarzban commented Feb 13, 2024

Hey @SamTV12345 , I just saw this notification and reviewed the code. You did a great job, but it's strange that the pipeline isn't working. Let me check; the backend test must have failed because the plugins also need refactoring. If I recall correctly, only the comments and WebRTC plugins require refactoring for this migration, while the others were fine.

I've identified the problem:
The pipeline is downloading the latest release of Etherpad, which isn't compatible with these changes.
I believe the best solution is to first test these changes with the new socket version and my branch in your local.
Then, if it works, we can proceed to merge the migration with the mainstream after the migration is complete.
After that, we can come back and update this repository to complete the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants