-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Replace Wanchain Testnet with HyperEVM (chainId 999) #7204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review. |
The @FrederikBolding @ligi could you please help with approving the CI workflows and the PR as well? |
@FrederikBolding @ligi bumping this PR 🙏 |
Still actual PR. Hyperevm has been live for some time, so seems like it is a critical entry in the list. |
Bumping, important issue. |
What is the status here? Any reason why this is not merged? Would be nice to have hyperEVM support in viem and this is one of the requirements. |
@ChiTimesChi @FrederikBolding How do we go ahead about merging this, I'm integrating hyperEVM and would really appreciate getting this merged if there are no blockers around it |
@ligi I see people are also pinging you for approvals, sorry if I'm spamming, I would just like to know what needs to be done to get this merged and who can approve it. In case there's something incorrect about this I can take a look and fix it, just let me know |
@pdjsh I think your best bet here is to find a repo contributor to open a new HyperEVM PR so that all CI workflows are run. It seems that for a new contributors like myself this isn't the case, which results in the PR being ignored by the repo maintainers |
Yeah, I don't know what's wrong with what you did, I think everything is done as described in the contributing section of the readme. I'll try to maybe open an issue to discuss it, see if there's any activity there. Not sure how else to find a contributor. Apologies to you too if I spammed you, just trying to get this thing done |
Replaces #6840, which seems to be stale.