eth/tracers: add txHash to pre-bedrock historical trace results #576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When querying debug_traceBlockXXX RPC methods on pre-Bedrock blocks, the txHash field is missing in the results.
Below is an example from block number 4, using
debug_traceBlockByNumber
with thecallTracer
:As you can see, txHash is set to a zero hash.
This PR initializes the txHash field using the corresponding transaction from the block that was traced.
real result:
Tests
Additional context
Metadata