core: add BlockTime to chain config
#607
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protolambda
reviewed
May 15, 2025
There was a problem hiding this comment.
There is some code that hydrates the chain config from superchain-registry data. That will need to be updated too. And the op-deployer code that generates a genesis config too. cc @bitwiseguy maybe you can help bridge with platforms team here on chain config changes?
params/config.go
Outdated
Comment on lines
454
to
456
|
|
||
| // Seconds per L2 block | ||
| BlockTime uint64 `json:"blockTime,omitempty"` |
There was a problem hiding this comment.
It would be good to call this config var out as an op-stack diff with a comment
There was a problem hiding this comment.
Done in fed1b3c.
Done in 41cbd5d.
Yeah I was planning to modify op-deployer after this PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently L2 block time is available in op-node here, but sadly not available in op-geth.
In the codebase there're many places that actually want the next block time, but it's computed as
parentHead.Time+1, which is not accurate.This PR introduces a
BlockTimefield to chain config and replaces all those places that want the next block time withconfig.NextBlockTime(parentHead.Time).