feat: refactor sent messages mapping #16402
Open
+18
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tynes
reviewed
Jun 13, 2025
| /// mapping if it has been sent from this chain to a destination chain. | ||
| mapping(bytes32 => bool) public sentMessages; |
There was a problem hiding this comment.
Small nit: the successfulMessages mapping doesn't use the named key/value
|
This only impacts the mapping on the send side and not the receive side, looks safe to me |
tynes
approved these changes
Jun 13, 2025
|
/ci authorize 919a0ba |
|
/ci authorize 81ac2b1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor of the
L2ToL2CrossDomainMessenger::sentMessagesmapping to improve traceability of message hashes and prepare the codebase for future features.