Skip to content

op-batcher: remove preferLocalSafeL2 flag #16413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

geoknee
Copy link
Contributor

@geoknee geoknee commented Jun 13, 2025

This behavior now becomes the default (in fact, the only) behavior. We only had this configurable before to cope with bugs in op-node which we believe are now either fixed or worked around adequately by the batcher.

#16298
#16296

This behavior now becomes the default (in fact, the only) behavior. We only had this configurable before to cope with bugs in op-node which we believe are now either fixed or worked around adequately by the batcher.
@geoknee geoknee requested review from a team as code owners June 13, 2025 10:42
@geoknee geoknee requested a review from axelKingsley June 13, 2025 10:42
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.39%. Comparing base (b227d03) to head (84fed65).

Files with missing lines Patch % Lines
op-batcher/batcher/driver.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b227d03) and HEAD (84fed65). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (b227d03) HEAD (84fed65)
cannon-go-tests-64 3 0
contracts-bedrock-tests 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #16413      +/-   ##
===========================================
- Coverage    47.08%   41.39%   -5.69%     
===========================================
  Files         1388     1197     -191     
  Lines       112185   100591   -11594     
===========================================
- Hits         52819    41644   -11175     
+ Misses       55658    55507     -151     
+ Partials      3708     3440     -268     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-batcher/batcher/config.go 35.95% <ø> (+0.39%) ⬆️
op-batcher/batcher/service.go 0.00% <ø> (ø)
op-batcher/batcher/sync_actions.go 100.00% <100.00%> (ø)
op-batcher/flags/flags.go 63.33% <ø> (ø)
op-batcher/batcher/driver.go 15.04% <0.00%> (ø)

... and 258 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant