Skip to content

move emission of EngineResetConfirmedEvent to happen only when TryUpdateEngineEvent handler succeeds #16414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

geoknee
Copy link
Contributor

@geoknee geoknee commented Jun 13, 2025

Closes #16351

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.31%. Comparing base (0f866d9) to head (ad89fe0).

❗ There is a different number of reports uploaded between BASE (0f866d9) and HEAD (ad89fe0). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (0f866d9) HEAD (ad89fe0)
cannon-go-tests-64 2 0
contracts-bedrock-tests 2 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #16414       +/-   ##
============================================
- Coverage    82.14%   45.31%   -36.83%     
============================================
  Files          161     1335     +1174     
  Lines         8883   108247    +99364     
============================================
+ Hits          7297    49055    +41758     
- Misses        1448    55679    +54231     
- Partials       138     3513     +3375     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 96.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-node/rollup/engine/events.go 76.83% <100.00%> (ø)

... and 1283 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

op-node/rollup/engine:EngineResetConfirmedEvent emitted before reset is actually confirmed
1 participant