Skip to content

op-devstack: Fix challenger funding #16419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Jun 13, 2025

Description

Fix op-devstack challenger funding logic.

There is currently a mismatch in how we fund challenger accounts and how we configure the challenger private key:

This PR fixes this by setting the challenger's private key from a funded L2 challenger key.

Other changes:

  • The WithSuperroots helper has been updated to use funded L2-specific keys for the proposer and challenger
  • The L2ChallengerID has been updated to follow the same pattern as L2ChallengerID. This allows us to pull the correct chainId when configuring the challenger.

Metadata

Part of: #15948

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.10%. Comparing base (281a750) to head (08211fc).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #16419       +/-   ##
============================================
+ Coverage    47.02%   67.10%   +20.08%     
============================================
  Files         1389       55     -1334     
  Lines       112410     4299   -108111     
============================================
- Hits         52859     2885    -49974     
+ Misses       55827     1276    -54551     
+ Partials      3724      138     -3586     
Flag Coverage Δ
cannon-go-tests-64 67.10% <ø> (ø)
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1334 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mbaxter mbaxter marked this pull request as ready for review June 13, 2025 20:11
@mbaxter mbaxter requested review from a team as code owners June 13, 2025 20:11
@mbaxter mbaxter requested a review from scharissis June 13, 2025 20:11
Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants