op-acceptance: Add tests for invalid messages to op-acceptance.#19242
Merged
op-acceptance: Add tests for invalid messages to op-acceptance.#19242
Conversation
ajsutton
force-pushed
the
aj/invalid-message-tests
branch
2 times, most recently
from
0c9aded to
f3d7ee8
Compare
ajsutton
added a commit
that referenced
this pull request
Feb 24, 2026
…erop flag Extracts genesis timestamp resolution out of WithSharedSupernodeCLsInterop and into withSharedSupernodeCLsImpl via a new UseGenesisInterop field on SupernodeConfig. Adds WithSupernodeInteropAtGenesis() option and threads snOpts through defaultSupernodeSuperProofsSystem so callers can pass supernode options independently of deployer options. Ported from #19242 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
ajsutton
added a commit
that referenced
this pull request
Feb 25, 2026
…erop flag Extracts genesis timestamp resolution out of WithSharedSupernodeCLsInterop and into withSharedSupernodeCLsImpl via a new UseGenesisInterop field on SupernodeConfig. Adds WithSupernodeInteropAtGenesis() option and threads snOpts through defaultSupernodeSuperProofsSystem so callers can pass supernode options independently of deployer options. Ported from #19242 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
…erop flag (#19302) * op-devstack: refactor genesis interop activation to use UseGenesisInterop flag Extracts genesis timestamp resolution out of WithSharedSupernodeCLsInterop and into withSharedSupernodeCLsImpl via a new UseGenesisInterop field on SupernodeConfig. Adds WithSupernodeInteropAtGenesis() option and threads snOpts through defaultSupernodeSuperProofsSystem so callers can pass supernode options independently of deployer options. Ported from #19242 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Skip failing test. * Move test that stops the batcher to its own package. * Skip one more test. --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
ajsutton
force-pushed
the
aj/invalid-message-tests
branch
from
44e14d1 to
a003f4f
Compare
ajsutton
added a commit
that referenced
this pull request
Mar 6, 2026
TestInteropFaultProofs_InvalidBlock and the ChainContinuesAfterReplacement sub-test in TestSupernodeInteropInvalidMessageReplacement both test supernode behavior that is not yet implemented (replacing invalid blocks and continuing to validate after replacement). Skip them with TODO(#19242) comments following the existing pattern in this codebase. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
ajsutton
force-pushed
the
aj/invalid-message-tests
branch
from
4cc9650 to
209185c
Compare
ajsutton
force-pushed
the
aj/invalid-message-tests
branch
from
209185c to
6548589
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #19242 +/- ##
===========================================
Coverage 75.2% 75.3%
===========================================
Files 680 485 -195
Lines 71998 60696 -11302
===========================================
- Hits 54184 45733 -8451
+ Misses 17670 14963 -2707
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ajsutton
force-pushed
the
aj/invalid-message-tests
branch
2 times, most recently
from
d649376 to
a61fe3d
Compare
Currently fail to setup because supernode doesn't actually remove the invalid transaction.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Skip until supernode removes invalid transactions from blocks. See #19411. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ajsutton
force-pushed
the
aj/invalid-message-tests
branch
from
a61fe3d to
49d6d86
Compare
wwared
approved these changes
Mar 20, 2026
op-acceptance-tests/tests/interop/proofs/serial/interop_fault_proofs_test.go
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently fail to setup because supernode doesn't actually remove the invalid transaction.
Tests
Additional context
Metadata