remove _proxy_ from opcm key name #897
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #897 +/- ##
=======================================
Coverage 43.68% 43.68%
=======================================
Files 39 39
Lines 2287 2287
=======================================
Hits 999 999
Misses 1200 1200
Partials 88 88 ☔ View full report in Codecov by Sentry. |
mds1
reviewed
Feb 14, 2025
| @@ -1,7 +1,7 @@ | |||
| name = "Sepolia" | |||
| protocol_versions_addr = "0x79ADD5713B383DAa0a138d3C4780C7A1804a8090" | |||
| superchain_config_addr = "0xC2Be75506d5724086DEB7245bd260Cc9753911Be" | |||
| op_contracts_manager_proxy_addr = "0xF564eEA7960EA244bfEbCBbB17858748606147bf" | |||
| op_contracts_manager_addr = "0xF564eEA7960EA244bfEbCBbB17858748606147bf" | |||
There was a problem hiding this comment.
Hm, this format is outdated too, and it should be something like this now:
Suggested change
| op_contracts_manager_addr = "0xF564eEA7960EA244bfEbCBbB17858748606147bf" | |
| [opcm] | |
| # Key refers to the L1 contracts release | |
| "v1.8.0" = "0x123..." | |
| "v2.0.0" = "0x456..." |
There was a problem hiding this comment.
actually this will need to be keyed by network name also
[opcm]
# Version key refers to the L1 contracts release
"v1.8.0" = {mainnet = "0x123...", sepolia = "0xabc..." }
"v2.0.0" = {mainnet = "0x456...", sepolia = "0xdef..." }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OPCM is no longer proxied. This just changes the name of the the key from
op_contracts_manager_proxy_addrtoop_contracts_manager_addr.No idea what this might break, hoping to find out here.