Add EIP: Box type for EIP-712 messages #8594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-new
File
|
eth-bot
added
e-consensus
xinbenlv
reviewed
May 23, 2024
abcoathup
reviewed
May 23, 2024
Co-authored-by: xinbenlv <[email protected]>
Co-authored-by: Andrew B Coathup <[email protected]>
github-actions
bot
added
w-ci
eth-bot
changed the title
frangio
commented
May 24, 2024
EIPS/eip-7713.md
Outdated
|
|
||
| Special-purpose interfaces improve usability and security for the user, but rely on standardized message types such as Permits. This EIP concerns the ability to standardize messages that contain within them parameters of arbitrary type. | ||
|
|
||
| A recent example is found in [ERC-7683](https://ercs.ethereum.org/ERCS/erc-7683), which defines a struct with the following member: |
There was a problem hiding this comment.
This ERC was created post-split. Is there a guideline to link to ERCs now?
There was a problem hiding this comment.
It's still ./eip-7683.md. The repos get merged during the build.
There was a problem hiding this comment.
That doesn't seem to work. Getting this error:
unable to read file
eip-7683.md: Io: JsValue(Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
There was a problem hiding this comment.
Yikes, that's a bug in our stuff. Opened an issue here: #8689
cum8197
approved these changes
May 28, 2024
frangio
changed the title
eth-bot
changed the title
This reverts commit dd596a0.
11 tasks
SamWilsn
approved these changes
Jun 25, 2024
|
The commit 27c129e (as a parent of 3d3005c) contains errors. |
Scamreno
added a commit
to Scamreno/EIPs
that referenced
this pull request
Jun 27, 2024
This reverts commit e1ec3e7.
Marcosmk12
approved these changes
Jul 10, 2024
Marcosmk12
approved these changes
Jul 10, 2024
Magken91
approved these changes
Jul 23, 2024
Magken91
approved these changes
Jul 23, 2024
GIgako19929
approved these changes
Sep 13, 2024
|
|
||
| ```js | ||
| { | ||
| domain: ..., |
| primaryType: 'Envelope', | ||
| types: { | ||
| Envelope: [ | ||
| { name: 'account', type: 'address' }, |
| primaryType: 'Envelope', | ||
| types: { | ||
| Envelope: [ | ||
| { name: 'account', type: 'address' }, |
There was a problem hiding this comment.
0xA29BEd6D482668b8eA351932A48D128E272E2a94
GIgako19929
approved these changes
Sep 13, 2024
AndyAkin
reviewed
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.