chore(ci): update actions/upload|download-artifact from v3 to v4

[skylenet]

Due to deprecation notice: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

[nflaig]

Just bumping the version is not sufficient, we need to adapt the workflows to work with v4 as there are behavior changes.

Last time I tried upgrading to v4 was in #462 but I didn't get it to work and had done a lot of other changes so I skipped upgrading those. They changed how files are copied and how to deal with existing directories, iirc it throws an error if a directory already exists. There is a overwrite flag (see inputs) but the problem there was it would overwrite the whole folder and since we run this as a matrx it would only keep the last release.

beacon-APIs/.github/workflows/deploy.yaml

Line 21 in 1cf1ada

matrix:

There is probably a way to tweak this (ie. by using different folders) to make it work but this needs to be tested in a forked repo first.

[nflaig]

https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md might be helpful

[nflaig]

I opened a PR #487 which updates the workflows to work with v4