Skip to content

Apply oneOf to submit attestations api as intended#503

Merged
nflaig merged 2 commits intomasterfrom
nflaig/fix-oneof
Feb 14, 2025
Merged

Apply oneOf to submit attestations api as intended#503
nflaig merged 2 commits intomasterfrom
nflaig/fix-oneof

Conversation

@nflaig
Copy link
Member

@nflaig nflaig commented Feb 14, 2025

The intend of #492 was to apply oneOf to submitPoolAttestationsV2 but it was applied to getPoolAttestationsV2 which causes issues as outlined here #492 (comment).

Alternative would just be to use anyOf everywhere

nflaig added a commit that referenced this pull request Feb 14, 2025
@mcdee
Copy link
Contributor

mcdee commented Feb 14, 2025

Oops, thanks for the catch.

Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nflaig nflaig merged commit d7ccaf6 into master Feb 14, 2025
3 checks passed
@nflaig nflaig deleted the nflaig/fix-oneof branch February 14, 2025 20:45
nflaig added a commit that referenced this pull request Feb 17, 2025
* Show most recent fork as default example in api explorer

* Remove unrelated change fixed separately in #503

---------

Co-authored-by: Paul Harris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants