chore: Add static point at infinity test case #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
changed the title
|
@kevaundray gosh, thanks for catching, wouldn't rhe result change as weill ? |
|
@kevaundray hold on semantically the tests are identical. you do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the g1 version of 2g1+inf inline with the g2 version.
It is testing the case where we want to do a size 2 multiexp aG + bH , where H is the point at infinity versus bH being the point at infinity because b=0.
This edge case is important because many clients have code that filters out the point at infinity due to some libraries not handling them gracefully in an MSM.