Skip to content

Conversation

ahshum
Copy link

@ahshum ahshum commented Oct 11, 2025

As validation around block.parent_root

- [REJECT] The block's parent (defined by `block.parent_root`) passes
validation.

is going to be removed in Gloas, I believe the new validation should be using bid instead

- [REJECT] The block's parent (defined by `block.parent_root`) passes
validation.

This PR aims to fix the added validation (the latter).

@ahshum
Copy link
Author

ahshum commented Oct 11, 2025

If the latter rule is needed and intended, should it make sense to remove both from spec?

Copy link
Contributor

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I believe that should be bid, thanks!

Copy link
Contributor

@potuz potuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potuz
Copy link
Contributor

potuz commented Oct 12, 2025

The wording in p2p is a bit weird now. The issue is that in the Phase 0 spec we already have this condition

- _[REJECT]_ The block's parent (defined by `block.parent_root`) passes
  validation.

Which was later modified in Bellatrix with the addition of the execution payload condition. This line should not be removed in Gloas, just that the validity of the payload is not necessarily required. That is, the original Phase0 statement should remain.

The check added in this PR should simply be that the bid's parent block root should be equal to the block's parent block root, since the validity of said block is guaranteed by that phase0 line.

@ahshum
Copy link
Author

ahshum commented Oct 12, 2025

That makes sense to me. So should I delete the entry for the removed rule and update the wording and statement of the added rule?

@ahshum ahshum requested review from potuz and terencechain October 13, 2025 09:27
@jtraglia jtraglia changed the title fix: gloas beacon_block validation eip7732: use bid in block parent validation Oct 13, 2025
@jtraglia jtraglia added the eip7732 ePBS label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants