eip7732: use bid in block parent validation#4648
Conversation
|
If the latter rule is needed and intended, should it make sense to remove both from spec? |
terencechain
left a comment
There was a problem hiding this comment.
yes, I believe that should be bid, thanks!
|
The wording in p2p is a bit weird now. The issue is that in the Phase 0 spec we already have this condition Which was later modified in Bellatrix with the addition of the execution payload condition. This line should not be removed in Gloas, just that the validity of the payload is not necessarily required. That is, the original Phase0 statement should remain. The check added in this PR should simply be that the bid's parent block root should be equal to the block's parent block root, since the validity of said block is guaranteed by that phase0 line. |
|
That makes sense to me. So should I delete the entry for the removed rule and update the wording and statement of the added rule? |
As validation around
block.parent_rootconsensus-specs/specs/gloas/p2p-interface.md
Lines 171 to 172 in ca5f3cd
is going to be removed in Gloas, I believe the new validation should be using
bidinsteadconsensus-specs/specs/gloas/p2p-interface.md
Lines 181 to 182 in ca5f3cd
This PR aims to fix the added validation (the latter).