eip7732: swap beacon_block_root and slot in places in DataColumnSidecar
#4656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine with this, but anyway wouldn't the schema be identified by the fork digest in the message? if the peer is sending the wrong type anyway we'd reject it. |
In gossipsub, yes. But this is useful property to have in range sync, persistence and other things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps
beacon_block_rootandslotin places inDataColumnSidecar.Motivation: There are currently two versions of
DataColumnSidecar. During deserialization from SSZ, it can be tricky to determine which container version to deserialize into. Having the same byte offset for theslotfield in both versions allows clients to read theslotvalue from the bytes (and thus gain insight into the container version) before full deserialization.