Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new MEV diagram on the MEV page #13781

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

nloureiro
Copy link
Contributor

The new MEV diagram on the MEV page

@nloureiro nloureiro linked an issue Sep 2, 2024 that may be closed by this pull request
@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Sep 2, 2024
Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit e30c148
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66d5f41a07e5b30008c79cd3
😎 Deploy Preview https://deploy-preview-13781--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 47 (🔴 down 3 from production)
Accessibility: 94 (🟢 up 2 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nloureiro
Copy link
Contributor Author

@aslikaya @LauraSinisterra I've added the image on the page

https://deploy-preview-13781--ethereumorg.netlify.app/en/developers/docs/mev/#maximal-extractable-value

Is it too big? Users need to click on it to read it. I think it's okay, but let me know what you think.

@nloureiro nloureiro self-assigned this Sep 2, 2024
@aslikaya
Copy link
Contributor

aslikaya commented Sep 2, 2024

Yes, it needs to be clicked to read it, I even want to zoom in :) Since the diagram is too big, the writings need to be small to fit in I guess. As far as I remember, most ethereum.org users access via mobile phones, but this is an advanced topic on builders docs so it may not be a big issue. If it is still a concern, we might need to remove some detailed info.

@nloureiro
Copy link
Contributor Author

@aslikaya, at this point, mobile and desktop access to ethereum.org are split 50/50, and the dev docs get a bit more desktop use than the rest of the pages.

This is a complex diagram, but @LauraSinisterra, can we make the text a bit bigger to avoid zooming on the fullscreen image? And if possible, to reduce some space 🙌

@aslikaya, do we still want to make a simpler diagram for the top of the page? might help to compensate the complexity of this one and could be one that the user don´t need zoom to understand

@aslikaya
Copy link
Contributor

aslikaya commented Sep 3, 2024

@nloureiro Yes you are right, a simpler diagram would be nice at the top

@nloureiro
Copy link
Contributor Author

@nloureiro Yes you are right, a simpler diagram would be nice at the top

Let's merge this one and then focus on the other one. ok?
Thank you for your contribution!

@LauraSinisterra
Copy link

LauraSinisterra commented Sep 7, 2024

Hi @nloureiro @aslikaya
Here's the updated diagram. I'm going to work on an alternative layout because this one looks a bit busy now.
For the simpler version, is there's any information I can remove or reduce? I'll replace most of the text with icons / and maybe make a legend so it is easier to understand.

MEV diagram - updated

@aslikaya
Copy link
Contributor

aslikaya commented Sep 8, 2024

I think we need to decide,

  1. if it is going to be a simpler version of the mev-boost
    I actually proposed another one about mev-boost on figma earlier, simpler than this but still I don't think it is a simple diagram :)

  2. Or about the MEV itself. There are different types of MEV such as frontrunning, backrunning and sandwich attacks.

The upper half of the MEV page is about what MEV is and its examples, the lower other half is about proposer-builder separation and its current off chain implementation (mev-boost). The most complicated part on the page, hard to understand without a diagram is definitely mev-boost.

@corwintines corwintines changed the base branch from dev to staging September 18, 2024 14:52
@corwintines corwintines merged commit b7dfdd3 into staging Sep 18, 2024
6 checks passed
@corwintines corwintines deleted the add-mev-diagrams-to-the-diagrams-page branch September 18, 2024 14:52
This was referenced Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MEV diagrams to the diagrams page
4 participants