-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new MEV diagram on the MEV page #13781
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@aslikaya @LauraSinisterra I've added the image on the page Is it too big? Users need to click on it to read it. I think it's okay, but let me know what you think. |
Yes, it needs to be clicked to read it, I even want to zoom in :) Since the diagram is too big, the writings need to be small to fit in I guess. As far as I remember, most ethereum.org users access via mobile phones, but this is an advanced topic on builders docs so it may not be a big issue. If it is still a concern, we might need to remove some detailed info. |
@aslikaya, at this point, mobile and desktop access to ethereum.org are split 50/50, and the dev docs get a bit more desktop use than the rest of the pages. This is a complex diagram, but @LauraSinisterra, can we make the text a bit bigger to avoid zooming on the fullscreen image? And if possible, to reduce some space 🙌 @aslikaya, do we still want to make a simpler diagram for the top of the page? might help to compensate the complexity of this one and could be one that the user don´t need zoom to understand |
@nloureiro Yes you are right, a simpler diagram would be nice at the top |
Let's merge this one and then focus on the other one. ok? |
Hi @nloureiro @aslikaya |
I think we need to decide,
The upper half of the MEV page is about what MEV is and its examples, the lower other half is about proposer-builder separation and its current off chain implementation (mev-boost). The most complicated part on the page, hard to understand without a diagram is definitely mev-boost. |
The new MEV diagram on the MEV page