Migrate EventCard to Shadcn #13966
Migrate EventCard to Shadcn #13966
Conversation
minimalsm
requested review from
wackerow,
corwintines and
pettinarip
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
agree. The spacing was off. Thank you for the adjustments comapring with Figma, the text size is bigger, but now we are bumping everything to 16 or above so let's keep it like this
With this text size, we should do a 2-card line. It's too narrow for an MD page. Would it be on another PR to do this?
|
|
Thanks @nloureiro
Okay can update to 16px fontsize. With that we can probably normalise line height too?
We can handle that in #13967, which is the upcoming events grid wrapper |
yes, makes sense
ok, got it |
|
Updated font size implementation after discussion with @nloureiro: Mobile: 16px font size Rationale:
Changes implemented && ready for review :) |
There was a problem hiding this comment.
@minimalsm looks good, will add a small fix to use cn function.
src/components/EventCard.tsx
Outdated
| w="full" | ||
| h="full" | ||
| <Card | ||
| className={`border-lightBorder flex h-full flex-col rounded-md border ${className}`} |
There was a problem hiding this comment.
Ah, what did you mean with lightBorder?
There was a problem hiding this comment.
No idea, just going to remove lol
Co-authored-by: Pablo Pettinari <[email protected]>
Description
Notes
Hardcoded 1.6rem line height for the description text (per OldText) as the defaults we have varied too much from the current design. Our designers should pull this component in line with current DS.
Slight differences in spacing compared to the original design (which had kind of unusual spacing). IMO, these are improvements but defer to @nloureiro
I've hardcoded the background colors (
bg-[#FCFCFC] dark:bg-[#272627]) in the CardHeader. Our default theme values didn't provide a good match for this use case. another area where we might want to consult with designRelated Issue
#13946