feat: migrate HorizontalCard to tailwind #14226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushagrasarathe
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
65 tasks
pettinarip
requested changes
Oct 31, 2024
Comment on lines
+29
to
+30
| <div className="text-lg">{title}</div> | ||
| <div className="text-base">{description}</div> |
There was a problem hiding this comment.
I think we could still use p tags here to keep the semantics
Suggested change
| <div className="text-lg">{title}</div> | |
| <div className="text-base">{description}</div> | |
| <p className="text-lg">{title}</p> | |
| <p className="text-base">{description}</p> |
| @@ -303,8 +303,8 @@ const GasPage = () => { | |||
| key={benefit.emoji} | |||
| emoji={benefit.emoji} | |||
| description={benefit.description} | |||
| className="text-5xl" | |||
| align="center" | |||
| emojiClassName="text-5xl" | |||
There was a problem hiding this comment.
5xl is the default size applied in HorizontalCard. We can remove, its just redundant.
Suggested change
| emojiClassName="text-5xl" |
| @@ -458,7 +458,7 @@ const StablecoinsPage = ({ markets, marketsHasError }) => { | |||
| <HorizontalCard | |||
| emoji={token.emoji} | |||
| description={token.description} | |||
| className="text-5xl" | |||
| emojiClassName="text-5xl" | |||
There was a problem hiding this comment.
Suggested change
| emojiClassName="text-5xl" |
| className="text-[2.5rem]" | ||
| alignItems="center" | ||
| className="my-0.5 w-[100%] items-center" | ||
| emojiClassName={"text-[2.5rem]"} |
There was a problem hiding this comment.
Suggested change
| emojiClassName={"text-[2.5rem]"} | |
| emojiClassName="text-[2.5rem]" |
| @@ -212,7 +212,7 @@ const CardContainer = (props: FlexProps) => ( | |||
| ) | |||
|
|
|||
| const TokenCard = (props: ComponentProps<typeof HorizontalCard>) => ( | |||
| <HorizontalCard minW="full" my={2} mx={0} borderRadius={0} {...props} /> | |||
| <HorizontalCard {...props} className="mx-0 my-2 min-w-full rounded-none" /> | |||
There was a problem hiding this comment.
We need to use the cn function here to merge the classNames. Otherwise, we will always override the className passed to TokenCard.
Suggested change
| <HorizontalCard {...props} className="mx-0 my-2 min-w-full rounded-none" /> | |
| <HorizontalCard className={cn("mx-0 my-2 min-w-full rounded-none", className)} {...props} /> |
| className="text-5xl" | ||
| align="center" | ||
| emojiClassName="text-5xl" | ||
| className="flex items-center py-2" |
There was a problem hiding this comment.
Suggested change
| className="flex items-center py-2" | |
| className="flex items-center" |
pettinarip
requested changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates
HorizontalCardcomponent to tailwind from ChakraDescription
This PR updates the HorizontalCard to use tailwindcss instead of Chakra ui. Styles have been updated for both light and dark version.
Related Issue
#13946