Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration-RollupProductDevDoc.tsx-to-tailwind #14268

Merged

Conversation

cqw-acq
Copy link
Contributor

@cqw-acq cqw-acq commented Oct 31, 2024

migration-RollupProductDevDoc.tsx-to-tailwind

Description

i migrationed RollupProductDevDoc.tsx to tailwind

### Snapshot

localhost:
截屏2024-10-31 11 13 00

ethereum.org:
截屏2024-10-31 11 13 05

Related Issue

#13946

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 2b349de
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67289870a656e30008fd7118
😎 Deploy Preview https://deploy-preview-14268--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 47 (🔴 down 8 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@cqw-acq cqw-acq mentioned this pull request Oct 31, 2024
65 tasks
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cqw-acq thanks for the PR! almost there, left a few tiny changes.

src/components/RollupProductDevDoc.tsx Outdated Show resolved Hide resolved
src/components/RollupProductDevDoc.tsx Outdated Show resolved Hide resolved
src/components/RollupProductDevDoc.tsx Outdated Show resolved Hide resolved
@cqw-acq
Copy link
Contributor Author

cqw-acq commented Nov 1, 2024

@pettinarip done!

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @cqw-acq

@isabelladebrito isabelladebrito added the hacktoberfest Track hacktoberfest activity label Nov 7, 2024
@pettinarip pettinarip merged commit 6bcd149 into ethereum:dev Nov 7, 2024
9 of 10 checks passed
Copy link

gitpoap-bot bot commented Nov 7, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Track hacktoberfest activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants