Generate Copier files #890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #890 +/- ##
==========================================
- Coverage 98.26% 98.14% -0.12%
==========================================
Files 130 130
Lines 15677 15753 +76
==========================================
+ Hits 15405 15461 +56
- Misses 272 292 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
reviewed
May 15, 2024
| @@ -13,6 +13,7 @@ TEST_F(state_transition, block_apply_withdrawal) | |||
| static constexpr auto withdrawal_address = 0x8888_address; | |||
|
|
|||
| block.withdrawals = {{0, 0, withdrawal_address, 3}}; | |||
| block.timestamp = 1; | |||
There was a problem hiding this comment.
I think you can put this as a default to state_transition.block definition in state_transition.cpp
… generating tests with empty prestate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates ethereum tests "Copier" files by executing
evmone-unittestswhen an output path is defined in theEVMONE_EXPORT_TESTSenv variable.Related PRs
Generated Copier Tests
This generates 2 directories containing the copier files:
eof_validationstate_transitionOptionally, these directories can be symlinks to the corresponding directories in the ethereum tests:
eof_validation -> <ethereum_tests_path>/src/EOFTestsFiller/efValidation/eof_validation/stack -> ../efStackstate_transition -> <ethereum_tests_path>/src/EIPTestsFiller/StateTests/stEOF/This is the list of generated state tests generated (See ethereum tests PR:
eof_validation:
state_transition:
blockwithdrawals,BLOCKHASH, ommer blocks, blob base fee.Other changes
blockstate transition tests, but they are currently skipped, instead it is now checking for thecallstate tests.pre: {},storage: {}.senderSecretKey, retesteth does not accept secret keys to have leading zeroes.