Skip to content

eth: improve filter API spec#633

Merged
fjl merged 1 commit intoethereum:mainfrom
prestwich:patch-1
Aug 25, 2025
Merged

eth: improve filter API spec#633
fjl merged 1 commit intoethereum:mainfrom
prestwich:patch-1

Conversation

@prestwich
Copy link
Contributor

@prestwich prestwich commented Feb 27, 2025

  • Filters do not register for notifications
  • filter IDs are required for many methods
  • the log filter object is required for the newFilter method
  • getFilterChanges returns an array of things depending on the filter

I do not know what getFilterLogs does, but the spec is identical to filter changes, so i suspect either

  • the spec is in error here and it returns only logs
  • the description is in error, and the name is misleading, and it may return block or tx hashes

- Filters do not register for notifications
- filter IDs are required for many methods
- the log filter object is required for the newFilter method
@fjl fjl changed the title correct filter api spec eth: improve filter API spec Aug 25, 2025
@fjl fjl merged commit 3c429f5 into ethereum:main Aug 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments