-
Notifications
You must be signed in to change notification settings - Fork 157
chore(ci): bump prague to stable and osaka to develop #1573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Actually requires #1508 if we want to wait for the last Prague-as-develop release. |
3b9397c
to
05f02d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a couple of requests:
- We need to remove the
is_deployed
method from Prague insrc/ethereum_test_forks/forks/forks.py
. - This is a breaking change in the changelog.
05f02d1
to
8d3f30b
Compare
Made the fixes for this, but some unit tests are failing, particularly the |
07867bb
to
214e430
Compare
d3e7cbc
to
1f75234
Compare
@marioevz @spencer-tb I think we need to get this merged, cf #1856. It's going to make our ci v slow π’ I just rebased on main, I think we'll have some tests to fix. |
Looking at just now! |
Didn't quite get there but these are the remaining tests to be fixed. Can continue next week. tests/prague/eip6110_deposits/test_modified_contract.py:
tests/prague/eip7702_set_code_tx/test_set_code_txs_2.py:
|
@spencer-tb thanks so much. @spencer-tb @marioevz @felix314159 ideally, we'd update |
5d2dd36
to
b4dbc2d
Compare
I rebased on main so that i can start helping, otherwise i would struggle with the solc-select dependency |
After modifying the
Should we update the eels_resolutions.json in a separate PR? |
b4dbc2d
to
02ac50b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, rebased to latest main to see if CI is fixed with the EELS update, will merge afterwards!
|
Found the issue, I think the master branch of eels is currently ignoring the |
Pushed one fix but this still requires a fix from EELS side: ethereum/execution-specs#1312 And even with that, some tests are still failing :( |
Example of test failing: tests/prague/eip2537_bls_12_381_precompiles/test_bls12_variable_length_input_contracts.py is timing out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Edit: Oops, didn't see the failing tests.
2 failing framework tests I haven't figured out, you can run them with:
For some reason the balance of these accounts is off by |
The remaining EELS failures are connection refused issues that come from increased parallelism. When running these failures isolated they pass. |
defaad7
to
c211070
Compare
These seem to be from some recent commits in EELS master. I dropped some of them and added the required commits (2 additional). We are now using a very similar EELS branch for Prague but on my fork. I think all the tests will fill correctly now. So just the 2 small unit tests. |
The failing unit tests should be fixed by ethereum/execution-specs#1312, in combination with this commit I just pushed: c6aea49 |
c4953f5
to
9f73522
Compare
@spencer-tb rebased on main to resolve chnagelog conflicts. Once ethereum/execution-specs#1312 is merged we can update Prague in eels_resolutions.json to point to execution-specs then we should be able to merge? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGGGGGTM! π
Goodbye friend. I'm not going to miss you PR 1573. π |
ποΈ Description
Bumps Prague to stable and Osaka to develop in our CI.
Allows us to create an Osaka full release after merging this where
fixtures_stable
would contain Prague andfixtures_develop
up to Osaka (refill-ing all our existing tests).π Related Issues
Requires #1507 and #1454.
β Checklist