Skip to content

chore(benchmark): don't fill benchmark tests by default #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

spencer-tb
Copy link
Contributor

@spencer-tb spencer-tb commented Jul 17, 2025

πŸ—’οΈ Description

Updates EEST to not fill benchmark tests by default.

πŸ”— Related Issues or PRs

#1919

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@spencer-tb
Copy link
Contributor Author

spencer-tb commented Jul 17, 2025

Please check if I have missed anything. It looks like this is all we need!
Seems its running the benchmark tests in tox :P

@spencer-tb
Copy link
Contributor Author

I'm considering doing the same for -m slow...

@marioevz
Copy link
Member

Couple of questions:

  • How do we run benchmark tests then?
  • Does it still work if we add another -m in the command line?

@spencer-tb spencer-tb force-pushed the benchmark-tests-not-default branch from b035560 to 18eb694 Compare July 18, 2025 10:02
@spencer-tb
Copy link
Contributor Author

I added a better solution by modifying the benchmark conftest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants