Skip to content

core/txpool: add notice to Clear that is not meant for production code #31567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025

Conversation

lightclient
Copy link
Member

The Sync(..) function explicitly says not to rely on in production code, but it is used in Clear(..) so should add a similar mention.

Copy link
Contributor

@jwasinger jwasinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would also note this on the Add function wrt the sync flag

@lightclient
Copy link
Member Author

@jwasinger done, PTAL

jwasinger
jwasinger previously approved these changes Apr 9, 2025
@lightclient
Copy link
Member Author

@jwasinger can you approve again? Sorry I needed to fix a small typo.

@lightclient lightclient merged commit 60b922f into ethereum:master Apr 9, 2025
3 of 4 checks passed
@lightclient lightclient added this to the 1.15.8 milestone Apr 9, 2025
sivaratrisrinivas pushed a commit to sivaratrisrinivas/go-ethereum that referenced this pull request Apr 21, 2025
…ode (ethereum#31567)

The `Sync(..)` function explicitly says not to rely on in production
code, but it is used in `Clear(..)` so should add a similar mention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants