WIP: Enable shared clients on testsuite level #1285
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danceratopz
force-pushed
the
shared-client
branch
from
0802366 to
f5a315d
Compare
marioevz
reviewed
Jun 11, 2025
5 tasks
This commit implements shared client functionality to improve resource efficiency by allowing clients to be reused across multiple tests in a test suite. Key features include: - New API endpoints for shared client management - Data structures for tracking shared client state - Log segment extraction for proper test result attribution - Integration with hiveview for log display - Documentation updates for all new methods and types
Added comprehensive unit tests for shared client functionality, including: - TestStartSharedClient - Tests the StartSharedClient method - TestAddSharedClient - Tests shared client registration in suites - TestSharedClientLogOffset - Tests log offset tracking - TestSharedClientLogExtraction - Tests log extraction - TestGetClientLogOffset - Tests the GetClientLogOffset function Also added ExecSharedClient method to Simulation type to support executing commands in shared clients
…stances When multiple clients of the same type exist in a suite, auto-registration now selects the most recently created client instead of skipping registration entirely. This ensures that tests properly register with a shared client even when multiple instances of the same client type are running.
Add line number tracking to shared client log segments to enable proper highlighting in the UI. Adds a line counting algorithm to convert byte positions to line numbers and enhances related data structures.
Updates the UI to properly display log links for shared clients with line range highlighting. Enhances client detection logic to work with multiple client instances of the same type, and improves the log viewer to properly highlight line ranges.
marioevz
reviewed
Jul 2, 2025
| } | ||
|
|
||
| // ClientLogSegment represents a segment of a client log file | ||
| type ClientLogSegment struct { |
There was a problem hiding this comment.
I tried to make sense of all the logging situation but I could not quite figure it out.
IMO I think it's not really functional at this point and we should just remove it from this PR and add it in a follow-up PR.
marioevz
reviewed
Jul 3, 2025
hivesim/data.go
Outdated
Comment on lines
27
to
30
| type LogOffset struct { | ||
| Start int64 `json:"start"` // Byte offset where this section begins | ||
| End int64 `json:"end"` // Byte offset where this section ends | ||
| } |
There was a problem hiding this comment.
This slipped, it's no longer necessary I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for "shared clients", a new type of client that allows the client's instance (container) to be reused across multiple tests within a test suite. The aim is to preserve client state between tests in order to allow multiple EL tests to be executed against a single running client container to avoid client start-up time and speed-up testing.
Backend
hivesim/hive.gowith methods:StartSharedClientandGetSharedClientInfo.hivesim/testapi.gowithAddSharedClientandGetSharedClient.hivesim/data.gofor tracking shared client state.Frontend
Testing
shared_client_test.gothat cover all major functionality:TestStartSharedClient: Tests client creation at the suite levelTestAddSharedClient: Tests client registration and retrieval in testsTestSharedClientLogOffset: Tests log position trackingTestSharedClientLogExtraction: Tests log segmentationTestGetClientLogOffset: Tests the log offset API